WordPress NLWeb plugin: apply review feedback#405
Draft
Copilot wants to merge 2 commits intowordpress-pluginfrom
Draft
WordPress NLWeb plugin: apply review feedback#405Copilot wants to merge 2 commits intowordpress-pluginfrom
Copilot wants to merge 2 commits intowordpress-pluginfrom
Conversation
Co-authored-by: rvguha <5252362+rvguha@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add WordPress NLWeb plugin implementation
WordPress NLWeb plugin: apply review feedback
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses a batch of correctness, security, and polish issues flagged in the initial plugin review.
Bug Fixes
class-nlweb-settings.php: Default models corrected (gpt-4.1-mini→gpt-4o-mini)class-nlweb-llm.php: Addedopenaiprovider case tobuild_request/parse_response— previously onlyopenrouterwas handled, so selecting "OpenAI" in settings silently failed; addederror_logon all failure pathsclass-nlweb-query-rewriter.php:fanout_searchdeduplication used non-existentidfield; switched tourl, with fallback for both associative arrays and numeric tuples[url, schema_json, name, site]; converted file from tabs to spaces to match the rest of the pluginSecurity
nlweb-mcp-renderer.js: Removedallow-same-originfrom sandbox.allow-scripts+allow-same-origintogether allow the iframe to remove its own sandbox attribute, fully bypassing isolation. UpdatedsetupMessageListenerto useevent.sourcefor validation since sandboxed null-origin iframes can't be validated by origin string.Polish
class-nlweb-handler.php: Fixed step comment label (4 → 5 for "Optionally summarize")nlweb-frontend.css:.page .wp-block-post-title { display:none }was hiding titles site-wide; scoped to.nlweb-fullpage-layoutclass-nlweb-retriever.php: Yoast extraction catch block now logs errors instead of swallowing them silentlyclass-nlweb-ranker.php: Comment wording fixclass-nlweb-frontend.php: Hardcoded sci-fi movie empty state replaced with generic defaults; addedempty_titleandempty_messageshortcode attributes for customization💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.