use standard .cache for build disk cache - #18
subtleGradient wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds explicit configuration options for the Expo build disk cache to ensure it remains enabled in all environments, particularly when using alternative package managers like flake.nix instead of homebrew.
- Adds explicit cache directory configuration pointing to
node_modules/.cache/expo-build-disk-cache - Configures cache garbage collection to run every 7 days
- Explicitly enables the cache and sets debug mode to false
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| "cacheGcTimeDays": 7, | ||
| "debug": false, | ||
| "enable": true |
There was a problem hiding this comment.
These three options are the default values, why did you add them here?
|
Why is cc @WookieFPV |
|
The default cache directory is a os specific temp directory ( I am not sure how and why flake.nix breaks caching. @subtleGradient could you provide more info/repro? |
PROBLEM:
the default options totally disable the disk cache
under some circumstances. e.g. when using flake.nix instead of homebrew
ALTERNATIVE:
instead of the standard node_modules/.cache, maybe ~/.cache
to allow sharing the build cache across many git worktrees