wrappers: expose platform wrapper modules via build.*Module options
#4020
+110
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattSturgeon
changed the title
build.*Module optionsbuild.*Module options
MattSturgeon
force-pushed
the
wrapper-module-options
branch
from
8daacc6 to
fb74fbc
Compare
Expose the platform wrapper modules as the Nixvim configuration options `build.nixosModule`, `build.homeModule`, and `build.nixDarwinModule`. This makes it possible to reuse a single Nixvim configuration across NixOS, Home Manager, and nix-darwin without re-importing modules into `programs.nixvim` manually. Evaluating these wrapper modules requires a "bare" Nixvim configuration; one that does not define `pkgs` or `nixpkgs.hostPlatform`. Such a configuration would normally fail to evaluate, but disabling `_module.check` provides a sufficiently lazy evaluation to access the wrapper options. To prevent the `_module.check = false` module from leaking into user configs, it has a unique module key and gets disabled inside the wrapper modules (`wrappers/_shared.nix`).
MattSturgeon
force-pushed
the
wrapper-module-options
branch
from
fb74fbc to
5a5f602
Compare
Member
Author
|
The edge-case where a user configures nixvim with platform-a, and then uses that configuration's That probably means choosing a higher override priority when propagating the host's Lines 42 to 44 in 8d085d4 Not necessarily in-scope for this PR though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change exposes the platform wrapper modules (
nixosModule,homeModule, andnixDarwinModule) as standard output options underbuild.*Modulewithin a Nixvim configuration. This allows users to take an existing Nixvim configuration and directly embed it into NixOS, Home Manager, or nix-darwin without re-importing modules intoprograms.nixvimmanually.To construct these wrapper modules we need to evaluate a minimal Nixvim configuration that contains no
pkgsornixpkgs.hostPlatform. Such a configuration would normally fail to eval, but evaluating it with_module.check = falseis lazy enough to read the wrapper options. This base module is marked with a unique key and is later disabled bywrappers/_shared.nixto prevent the no-check setting from leaking into user configurations.Fixes #4009