-
-
Notifications
You must be signed in to change notification settings - Fork 363
plugins/substitute: added plugin #4010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thank you for the quick response! I have changed the code as per your suggestions :) |
HeitorAugustoLN
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything else LGTM
|
Good catch, changed it so that aligns with that now. |
|
Fixed the ... of the inputs, the other comment was already resolved in an older commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I think you might need to squash your commits to:
maintainers: add fwastring
plugins/substitute: init
|
Thank you, I will do that. How do I request another review to be able to merge? |
|
Since you are not a maintainer yet, you can't request reviews, but I will request for you |
Added support for substitute.nvim.
Added tests and plugin support, and myself as a maintainer.