-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Twitter Sign In Added #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Twitter Sign In Added #146
Conversation
|
@upahar-khatiwada I will review and merge it by EOD today. Thank you for your contribution! |
|
any updates? @nisrulz |
nisrulz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to address the issue related to API key.
Also try to align how the Google Auth example is built.
| static const FirebaseOptions web = FirebaseOptions( | ||
| apiKey: 'AIzaSyAnRhs8FEly8Ro_8vZpyxNcDWeQC33EuIc', | ||
| appId: '1:651435915042:web:33ad8a8f66452e0fb1577b', | ||
| messagingSenderId: '651435915042', | ||
| projectId: 'firebase-twitter-login-upahar', | ||
| authDomain: 'fir-twitter-login-upahar.firebaseapp.com', | ||
| storageBucket: 'firebase-twitter-login-upahar.firebasestorage.app', | ||
| ); | ||
|
|
||
| static const FirebaseOptions macos = FirebaseOptions( | ||
| apiKey: 'AIzaSyDJ9K_Tj_gdGc_WgsJ-MQPYF1YRIm4EHNs', | ||
| appId: '1:651435915042:ios:bd5b9865f9a5bbb6b1577b', | ||
| messagingSenderId: '651435915042', | ||
| projectId: 'firebase-twitter-login-upahar', | ||
| storageBucket: 'firebase-twitter-login-upahar.firebasestorage.app', | ||
| iosBundleId: 'com.example.firebaseTwitterSignIn', | ||
| ); | ||
|
|
||
| static const FirebaseOptions windows = FirebaseOptions( | ||
| apiKey: 'AIzaSyAnRhs8FEly8Ro_8vZpyxNcDWeQC33EuIc', | ||
| appId: '1:651435915042:web:5e426e685fcc0d9cb1577b', | ||
| messagingSenderId: '651435915042', | ||
| projectId: 'firebase-twitter-login-upahar', | ||
| authDomain: 'fir-twitter-login-upahar.firebaseapp.com', | ||
| storageBucket: 'firebase-twitter-login-upahar.firebasestorage.app', | ||
| ); | ||
|
|
||
| static const FirebaseOptions ios = FirebaseOptions( | ||
| apiKey: 'AIzaSyDJ9K_Tj_gdGc_WgsJ-MQPYF1YRIm4EHNs', | ||
| appId: '1:651435915042:ios:bd5b9865f9a5bbb6b1577b', | ||
| messagingSenderId: '651435915042', | ||
| projectId: 'firebase-twitter-login-upahar', | ||
| storageBucket: 'firebase-twitter-login-upahar.firebasestorage.app', | ||
| iosBundleId: 'com.example.firebaseTwitterSignIn', | ||
| ); | ||
|
|
||
| static const FirebaseOptions android = FirebaseOptions( | ||
| apiKey: 'AIzaSyB_XhLYl_TjNND4wZOYGCVyAJEoJPPNd6k', | ||
| appId: '1:651435915042:android:2936ed840e5c74cbb1577b', | ||
| messagingSenderId: '651435915042', | ||
| projectId: 'firebase-twitter-login-upahar', | ||
| storageBucket: 'firebase-twitter-login-upahar.firebasestorage.app', | ||
| ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Reset your API keys because now you have exposed them.
- Change your code so it can accept a key from outside i.e from ENV variable. Then you provide this key from outside and would not need to hard code it in your code like you have done here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Take a look at how an existing example app was built here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also please add a valid readme under your directory to explain how to setup a personal key. The linked example above does that.
Pull Request
What does this implement/fix?
This PR implements Twitter login using Firebase Authentication for Flutter.
signInWithTwitterfunction usingFirebaseAuth’sTwitterAuthProvider.SnackBarmessages.HomeScreenafter successful login.Some Screenshots
Does this close any currently open issues?
Issue #21
Where has this been tested?
Target Platform:
Walkthrough:
HomeScreen