Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/release-please.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,12 @@ permissions:
jobs:
release-please:
runs-on: ubuntu-latest
env:
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true
steps:
- name: Run Release Please
id: release
uses: googleapis/release-please-action@v4.4.1
uses: googleapis/release-please-action@v5

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

🧩 Analysis chain

🌐 Web query:

What are the breaking changes in googleapis/release-please-action v5 compared to v4?

💡 Result:

Breaking changes in googleapis/release-please-action v5 compared to v4 are: 1) Node runtime upgrade (v4 → v5) - v5.0.0 includes a breaking change: “upgrade to node24”. [1] - Therefore, if you were relying on the action running on the earlier Node version from v4, you’ll need to ensure your GitHub Actions environment/workflow is compatible with Node 24 (the action itself now targets Node 24). [1] What’s not shown as a “breaking change” for v5 itself (based on the published v5.0.0 release notes) - The v5.0.0 release notes list only the Node 24 upgrade under “⚠ BREAKING CHANGES”. [1] Context: the main breaking changes introduced when moving to v4 (not directly “v5 vs v4”, but helps explain the prior baseline) - v4.0.0 breaking changes included: removing most configuration options in favor of manifest configuration, rewriting in TypeScript, removing the command option in favor of setting release-type and skip-github-release/skip-github-pull-request, and running on Node 20. [2][3] So, the delta from v4 to v5 that is explicitly called out as breaking in the v5 release is the Node 24 upgrade. [1]

Citations:


Ensure Node 24 compatibility for release-please-action v5.

The upgrade from v4.4.1 to v5 introduces a breaking change: v5 requires Node 24 (upgraded from Node 20 in v4). Verify that your GitHub Actions environment and runners support Node 24.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/release-please.yml at line 22, The workflow now uses
googleapis/release-please-action@v5 which requires Node 24; update the workflow
job to ensure a Node 24 runtime before invoking the action — e.g., add
actions/setup-node@v4 with node-version: '24' (or switch the runner to an image
that ships Node 24) in the same job prior to the uses:
googleapis/release-please-action@v5 step so the release-please-action runs on
Node 24.

with:
config-file: release-please-config.json
manifest-file: .release-please-manifest.json
manifest-file: .release-please-manifest.json
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Loading