Fix Memory Leak in track_error_benchmark#96
Open
Chi-hong22 wants to merge 1 commit intonilsbore:masterfrom
Open
Fix Memory Leak in track_error_benchmark#96Chi-hong22 wants to merge 1 commit intonilsbore:masterfrom
Chi-hong22 wants to merge 1 commit intonilsbore:masterfrom
Conversation
Author
|
@nilsbore Please review the code as soon as possible, this problem has bothered me for half a month, and there is no memory problem if you use your code before May |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Memory Leak in track_error_benchmark
Description
Fixed a memory leak issue in the track_error_benchmark class that occurred during nested vector destruction of grids data structures.
Problem
When destructing large nested vector structures containing Eigen matrices in the add_benchmark method, a memory corruption occurred at the vector destructor level. This typically happened with large datasets due to improper memory management of temporary grid maps.
The specific error occurred in:
Affecting the following nested vector structure:
Solution
The key changes include:
And explicit resource cleanup: