feat: add configurable adaptive thinking support (off by default)#45
Open
feat: add configurable adaptive thinking support (off by default)#45
Conversation
- The config plumbs through AskForgeClient → Session → processStream → pi-ai stream(). - The eval runner accepts a --thinking flag for A/B comparison runs.
kirang89
reviewed
Mar 18, 2026
Comment on lines
+12
to
+25
| export type ThinkingMode = "off" | "adaptive"; | ||
|
|
||
| /** | ||
| * Configuration for Claude's adaptive/extended thinking. | ||
| * Default: thinking is off. Enable via `mode: "adaptive"` for eval-gated rollout. | ||
| */ | ||
| export interface ThinkingConfig { | ||
| /** Thinking mode: "off" (default) or "adaptive" */ | ||
| mode: ThinkingMode; | ||
| /** Effort level for adaptive thinking (Anthropic Opus 4.6+ only). Default: "high" */ | ||
| effort?: "low" | "medium" | "high" | "max"; | ||
| /** Explicit token budget for extended thinking (older Anthropic models). Ignored for adaptive. */ | ||
| budgetTokens?: number; | ||
| } |
Contributor
There was a problem hiding this comment.
Some thoughts:
- I feel like the thinking mode could just be on/off with effort being low/medium/high/max/adaptive.
- Do you know how this setting would work with another model, say ChatGPT or Gemini. Does pi-ai provide a thinking config that we can re-use?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #38