Add window-closed event to subscribe command - #2199
Closed
mvulin11 wants to merge 1 commit into
Closed
Conversation
Broadcast window-closed from MacWindow.garbageCollect - the single funnel every close goes through (user close, app termination, close command). Payload mirrors window-detected: windowId, workspace, appBundleId, appName. Locking the screen makes all windows unobservable, which garbage collects them into the closed-windows cache and now emits window-closed. To keep subscribers' bookkeeping balanced, restoring a window from the cache (which deliberately skips on-window-detected callbacks) now broadcasts a matching window-detected event. Closes the gap tracked in nikitabobko#445 for subscribe consumers. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
mvulin11
added a commit
to mvulin11/AeroSpace
that referenced
this pull request
Jul 23, 2026
…opened Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Owner
That is exactly one of the reasons why I don't want to expose |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./test.shexits with non-zero exit code. (swift test: 382 tests, 0 failures)Single atomic commit; full motivation and design notes (including the lock-screen / closed-windows-cache interaction) are in the commit message. Related: #445.
🤖 Generated with Claude Code