Skip to content

Conversation

@yanndavin
Copy link

Add the possibility to get wubi codes for a characters sequence.
Add the possibility to get pinyin in utf8 with accent rather that ascii with tone digit code.

Add the possibility to get pinyin in utf8 with accent rather that ascii with tone digit code.
@nieldlr
Copy link
Owner

nieldlr commented Jan 24, 2019

This is really amazing @yanndavin! I'm so sorry I missed this completely. I would love to get this merged into HanziCraft. Especially the Pinyin accents too.

Would you be up for merging in the latest code to get some of the conflicts resolved? Let me know! Otherwise I could also possibly look into getting this merged.

Happy either way.

@codecov-io
Copy link

codecov-io commented Jan 26, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@a482fc7). Click here to learn what that means.
The diff coverage is 95.45%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #50   +/-   ##
=========================================
  Coverage          ?   88.67%           
=========================================
  Files             ?       17           
  Lines             ?      618           
  Branches          ?      101           
=========================================
  Hits              ?      548           
  Misses            ?       58           
  Partials          ?       12
Impacted Files Coverage Δ
lib/dictionary.js 88.3% <95.45%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a482fc7...12aa17f. Read the comment docs.

@yanndavin
Copy link
Author

I've looked for the merge but there is still errors on travis I don't explain. Any idea ?

@benlieb
Copy link

benlieb commented Mar 1, 2020

Looking forward to getting this in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants