Fix string min max #9
Open
+143
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rule params can now be used in the messages for replacement. They are collected together with the errors and forwarded to generateMessage to be used in DEFAULT_PLACEHOLDERS methods.
nicole-mcg
reviewed
Jul 12, 2019
Owner
nicole-mcg
left a comment
nicole-mcg
left a comment
There was a problem hiding this comment.
Looks good but there is a lot going on in this one, I should be able to look at it fully it in the next couple days. Thanks for your contributions btw! I will be updating npm with them asap
Co-Authored-By: Nik M <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I improved the min, max and between validator. It now works together with the "integer" and "number" validator. So the validation "integer|min:10" will be true even for the string "20". This is the same behaviour as Laravel.
In addition the parameters for a validation rule are now passed correctly to the generateMessage method and the error messages are now working.