Improve handling of multiple builds in .ninja_log#35
Merged
Conversation
When using `-a` mode, if `.ninja_log` contains multiple builds, produce a trace that is still sequential (with one incremental build after each other), instead of pretending tha tthey all happened at the same time.
Contributor
Author
|
Ping :) |
Owner
|
Sorry it took me so long to notice this PR. Anyways, I'm dusting off CI and this apparently breaks tests. #41 reverts this for now, but happy to merge it again with fixed tests. Maybe it'll take me less long to notice next time :) (Ping me on LLVM discord, "thakis".) Hopefully CI will check this on the PR next time. |
Contributor
Author
|
Done in #42 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
-amode, if.ninja_logcontains multiple builds, produce a trace that is still sequential (with one incremental build after each other), instead of pretending that they all happened at the same time.