Add test scenarios for analyze-project#36
Merged
Conversation
… apparently doesn't work on a composite action step
Collaborator
Author
|
@bkeryan Can you expand on what you expect for 'run again with cached venv'? Would this involve adding a 'use-cache' input to analyze-project to determine if it caches the venv? |
Collaborator
Run another job that uses the same venv. Use Example: https://github.com/ni/python-actions/blob/main/.github/workflows/test_actions.yml#L68 test_setup_poetry_cache_hit also does extra validation that I'm not expecting here. We should probably do that validation when we extract a cache_venv action. |
bkeryan
requested changes
Sep 29, 2025
bkeryan
reviewed
Sep 29, 2025
bkeryan
approved these changes
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Fixes #31
Add test scenarios with test projects for
Why should this Pull Request be merged?
Expands test coverage for analyze-project
What testing has been done?
Running this PR is exercising the new tests.