-
Notifications
You must be signed in to change notification settings - Fork 101
Fix: Add setuptools < 82 constraint for grpcio-tools compatibility #2163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Add setuptools < 82 constraint for grpcio-tools compatibility #2163
Conversation
grpcio-tools 1.59.0 requires pkg_resources which was removed in setuptools 70.0.0. This constraint ensures pkg_resources is available for the codegen environment. Fixes compatibility issue with grpcio-tools 1.59.0 when setuptools >= 70.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2163 +/- ##
=======================================
Coverage 90.09% 90.09%
=======================================
Files 71 71
Lines 18662 18662
=======================================
+ Hits 16813 16814 +1
+ Misses 1849 1848 -1
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
What are all these filemode changes? |
Filemode changes got added automatically though there were no changes specifically. I have updated the PR to show up only changes related to setuptools |
Should be checked off, not crossed out. |
I've updated CHANGELOG.md if applicable.I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
Adds
setuptools < 82constraint to the codegen environment in bothtox.iniandtox-travis.inito maintain compatibility withgrpcio-tools 1.59.0.grpcio-tools 1.59.0 depends on
pkg_resources, which was removed in setuptools 82.0.0. Without this constraint, the codegen environment fails when setuptools >= 82 is installed. Due to this, tox execution was failing in master.What testing has been done?