Skip to content

Conversation

@rahur-NI
Copy link
Contributor

@rahur-NI rahur-NI commented Feb 11, 2026

  • This contribution adheres to CONTRIBUTING.md.
  • I've updated CHANGELOG.md if applicable.
  • I've added tests applicable for this pull request

What does this Pull Request accomplish?

Adds setuptools < 82 constraint to the codegen environment in both tox.ini and tox-travis.ini to maintain compatibility with grpcio-tools 1.59.0.

grpcio-tools 1.59.0 depends on pkg_resources, which was removed in setuptools 82.0.0. Without this constraint, the codegen environment fails when setuptools >= 82 is installed. Due to this, tox execution was failing in master.

What testing has been done?

  • Successful local tox build verification with setuptools < 82 constraint applied
  • Validated that both tox.ini and tox-travis.ini are updated as needed.

grpcio-tools 1.59.0 requires pkg_resources which was removed in setuptools 70.0.0. This constraint ensures pkg_resources is available for the codegen environment.

Fixes compatibility issue with grpcio-tools 1.59.0 when setuptools >= 70.
@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.09%. Comparing base (f83c4a2) to head (f197483).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2163   +/-   ##
=======================================
  Coverage   90.09%   90.09%           
=======================================
  Files          71       71           
  Lines       18662    18662           
=======================================
+ Hits        16813    16814    +1     
+ Misses       1849     1848    -1     
Flag Coverage Δ
codegenunittests 84.44% <ø> (ø)
nidcpowersystemtests 94.65% <ø> (+0.04%) ⬆️
nidcpowerunittests 89.53% <ø> (ø)
nidigitalsystemtests 92.26% <ø> (ø)
nidigitalunittests 68.44% <ø> (ø)
nidmmsystemtests 92.72% <ø> (ø)
nifakeunittests 85.70% <ø> (ø)
nifgensystemtests 94.61% <ø> (ø)
nimodinstsystemtests 73.85% <ø> (ø)
nimodinstunittests 94.20% <ø> (ø)
nirfsgsystemtests 82.40% <ø> (ø)
niscopesystemtests 92.94% <ø> (ø)
niscopeunittests 43.20% <ø> (ø)
nisesystemtests 91.50% <ø> (ø)
niswitchsystemtests 82.03% <ø> (ø)
nitclksystemtests 94.87% <ø> (ø)
nitclkunittests 98.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f83c4a2...f197483. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rahur-NI rahur-NI marked this pull request as draft February 11, 2026 15:12
@ni-jfitzger
Copy link
Collaborator

What are all these filemode changes?

@rahur-NI rahur-NI changed the title Fix: Add setuptools < 70 constraint for grpcio-tools compatibility Fix: Add setuptools < 82 constraint for grpcio-tools compatibility Feb 11, 2026
@rahur-NI
Copy link
Contributor Author

What are all these filemode changes?

Filemode changes got added automatically though there were no changes specifically. I have updated the PR to show up only changes related to setuptools

@rahur-NI rahur-NI marked this pull request as ready for review February 11, 2026 16:02
@ni-jfitzger
Copy link
Collaborator

This contribution adheres to CONTRIBUTING.md.

Should be checked off, not crossed out.

@vnktshr21 vnktshr21 merged commit be77b68 into ni:master Feb 12, 2026
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants