fix(signals): expose readonly signals in slices #4959
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
withState
,signalState
, andwithLinkedState
now pass aSignal
instead of the originalWritableSignal
to the DeepSignal.This prevents accidental misuse where consumers (e.g.
ngModel
or other APIs with incompatible types) could assertWritableSignal
and write directly into the state.Closes #4958
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #4958
What is the new behavior?
Will throw an error if set is called because the Signal is readonly.
Does this PR introduce a breaking change?