Skip to content

Conversation

@mjang
Copy link
Contributor

@mjang mjang commented Oct 24, 2025

Proposed changes

Closes #1367

Checklist

Before sharing this pull request, I completed the following checklist:

Footnotes

  1. Potentially sensitive information includes personally identify information (PII), authentication credentials, and live URLs. Refer to the style guide for guidance about placeholder content.

@github-actions github-actions bot added documentation Improvements or additions to documentation product/waf Issues related to F5 WAF for NGINX labels Oct 24, 2025
@github-actions
Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/1368/

@mjang mjang marked this pull request as ready for review October 24, 2025 16:00
@mjang mjang requested a review from a team as a code owner October 24, 2025 16:00
Copy link
Contributor

@travisamartin travisamartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

However, I want a WAF SME to review/approve as well, since this is an install guide update and we’ve had a lot of issues with the WAF install guides. Something’s amiss with the WAF review process.

Cc: @ADubhlaoich @mouraddmeiri @rranghar @ohad-perets

@travisamartin travisamartin requested a review from a team October 24, 2025 16:26
ald8

This comment was marked as duplicate.

@ald8
Copy link
Contributor

ald8 commented Oct 27, 2025

Looks good.

However, I want a WAF SME to review/approve as well, since this is an install guide update and we’ve had a lot of issues with the WAF install guides. Something’s amiss with the WAF review process.

Cc: @ADubhlaoich @mouraddmeiri @rranghar @ohad-perets

I am not the codeowner but the configs look fine!

@mjang
Copy link
Contributor Author

mjang commented Oct 28, 2025

  • I've accepted the changes suggested by @aknot242 . (I would have sworn he's made the same changes in another recent PR)
  • We now have an approval from a member of the waf group, @mouraddmeiri . So I think we've now met the requirement from @travisamartin for approval from an SME

@travisamartin travisamartin dismissed their stale review October 28, 2025 15:02

Unblocking since we have SME review/approval now.

@mjang mjang merged commit 4d5c4e4 into main Oct 28, 2025
9 checks passed
@mjang mjang deleted the fix-virt-env branch October 28, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation product/waf Issues related to F5 WAF for NGINX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Wrong NGINX configuration files for NGINX + WAF on VM/bare metal

7 participants