Skip to content

Added padding to subtitleView container height. #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pjvea wants to merge 3 commits into
base: master
Choose a base branch
from
+4 −2
Open

Added padding to subtitleView container height. #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6fc73de
Added padding to subtitleView container height.
pjvea Apr 2, 2019
065961e
Updated container height logic.
pjvea Apr 2, 2019
189f66b
Improved subtitleView height logic.
pjvea Apr 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion SMCalloutView.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,8 +197,10 @@ - (CGFloat)calloutHeight {
- (CGFloat)calloutContainerHeight {
if (self.contentView)
return self.contentView.frameHeight + self.contentViewInset.bottom + self.contentViewInset.top;
else if (self.subtitleView || self.subtitle.length > 0)
else if (self.subtitle.length > 0)
return CALLOUT_SUB_DEFAULT_CONTAINER_HEIGHT;
else if (self.subtitleView)
return CALLOUT_SUB_DEFAULT_CONTAINER_HEIGHT + self.subtitleView.frameHeight - 15;
else
return CALLOUT_DEFAULT_CONTAINER_HEIGHT;
}
Expand Down
2 changes: 1 addition & 1 deletion SMCalloutView.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Pod::Spec.new do |s|
s.name = "SMCalloutView"
s.version = "2.1.5"
s.version = "2.1.6"
s.summary = "A lightweight callout view class for iOS mimicking UICalloutView."
s.description = <<-DESC
SMCalloutView aims to be an exact replica of the private UICalloutView system control.
Expand Down