This repository was archived by the owner on Jun 13, 2024. It is now read-only.
Make cell type mappings file really optional#26
Open
pinin4fjords wants to merge 2 commits intonf-core:devfrom
Open
Make cell type mappings file really optional#26pinin4fjords wants to merge 2 commits intonf-core:devfrom
pinin4fjords wants to merge 2 commits intonf-core:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cell type mappings file is supposed to be optional. However, the workflow structure doesn't current allow for that, and even the test profile fails accordingly.
This just adds a conditional around any process dependent on that file, directly or indirectly.
PR checklist
nf-core lint).nextflow run . -profile test,docker).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).