Skip to content
This repository was archived by the owner on Jun 13, 2024. It is now read-only.

Make cell type mappings file really optional#26

Open
pinin4fjords wants to merge 2 commits intonf-core:devfrom
healx:make_ct_mappings_really_optional
Open

Make cell type mappings file really optional#26
pinin4fjords wants to merge 2 commits intonf-core:devfrom
healx:make_ct_mappings_really_optional

Conversation

@pinin4fjords
Copy link
Member

The cell type mappings file is supposed to be optional. However, the workflow structure doesn't current allow for that, and even the test profile fails accordingly.

This just adds a conditional around any process dependent on that file, directly or indirectly.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/scflow branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@pinin4fjords pinin4fjords marked this pull request as draft March 22, 2023 16:22
@pinin4fjords pinin4fjords marked this pull request as ready for review March 22, 2023 16:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant