Skip to content

Conversation

@delfiterradas
Copy link
Contributor

@delfiterradas delfiterradas commented Nov 27, 2025

PR checklist

Closes nf-core/differentialabundance#515

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@delfiterradas delfiterradas self-assigned this Nov 27, 2025
Copy link
Member

@pinin4fjords pinin4fjords left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! The approach of using limma::makeContrasts() to parse complex contrast strings makes sense.

One thing I wanted to check - in the new limma branch, the shrinkage result is assigned to comp.shrunk:

comp.shrunk <- run_shrink(contrast = numeric_contrast)

But in the existing code path, it's assigned to comp.results:

comp.results <- run_shrink(coef = opt$contrast_string)

Is this intentional? I couldn't see comp.shrunk being used elsewhere, so I wondered if it should be comp.results for consistency - but I may be missing something.

Also noticed the test uses --shrink_lfc FALSE, so it might be worth adding a case with shrinkage enabled to cover that path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

With DESeq2, when using formula, can only use coefficient names, but not complex contrasts

2 participants