-
Notifications
You must be signed in to change notification settings - Fork 142
Add binner SemiBin2 #930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add binner SemiBin2 #930
Conversation
|
@nf-core-bot fix linting |
Investigated CI test outcomes:
Conclusion: Most tests might be fine, but not long reads only tests. I'll see what I can do to make them pass. |
dialvarezs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very clean!
Minor comments from my end.
|
Profile Thanks for all the comments and the reviews! |
Adds SemiBin2, related to #874
SemiBin2 handles cases where it finds no bins gracefully: exit code 0. It does error though when there are too less contigs (but I could not find how many are required). Therefore errors dont need to be ignored, I think.
Whenever long reads are used in the assembly (if
meta.lr_platform) then long read binning mode is activated. However I am not sure that is supposed to be used for SPAdes assemblies, because they are (at least last time I checked) short read assembles with long read stitching. But I follow the FAQWhat should I do if I have hybrid data (short- and long-reads)? From SemiBin's point-of-view, you should generally treat this using the long-reads pipeline (--sequencing-type=long_read).from here.About CI tests:
test_alternativesshould work as well and could be activated (requires snap update though)longreadonly&longreadonly_alternativesproduce assemblies with only 3 contigs, SemiBin2 complains; couldnt find any required minimum contig number though.Still to do:
-profile test_fullpending (test running atm)PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).