Add MethodExtension to ServiceHandlerInstance - #19
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 432f618ccc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| /// Result of an <see cref="IMethodExtension"/> matching a method: the operation name it | ||
| /// handles and the operation handler for it. | ||
| /// </summary> | ||
| public sealed class MethodExtensionResult |
There was a problem hiding this comment.
Move MethodExtensionResult out of this file
This project treats analyzer warnings as errors via Directory.Build.props, and SA1402 is not disabled globally; adding MethodExtensionResult as a second top-level type in IMethodExtension.cs will trigger the same StyleCop rule that the existing multi-type OperationStartResult.cs has to suppress locally. Move this class to its own file or add an explicit suppression, otherwise builds that run analyzers fail before tests execute.
Useful? React with 👍 / 👎.
Add
MethodExtensiontoServiceHandlerInstance. This allows users, like the Temporal SDK, to define custom attributes on service handlers.This will allow us to define Nexus Service like so.
See also temporalio/sdk-dotnet#764