Add Failure with spec-compliant metadata/details - #17
Merged
Conversation
docfx 2.78.5 requires .NET 10.0 runtime which isn't available on the macOS GitHub Actions runner. Pin to 2.77.x which targets .NET 8.0. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The newer macOS runners no longer have .NET 8 preinstalled, causing docfx 2.77.0 (targets net8.0) and tests to fail. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Quinn-With-Two-Ns
marked this pull request as ready for review
March 16, 2026 16:51
| - name: Build docs | ||
| run: | | ||
| dotnet tool update -g docfx | ||
| dotnet tool update -g docfx --version "2.77.*" |
Contributor
Author
There was a problem hiding this comment.
This may not be needed, need to do bit more research
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 01f784b008
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
VegetarianOrc
approved these changes
Mar 17, 2026
Comment on lines
+47
to
+64
| [Fact] | ||
| public void StackTraceOverrideReturnsProvidedValue() | ||
| { | ||
| var ex = new HandlerException( | ||
| HandlerErrorType.Internal, | ||
| "fail", | ||
| null, | ||
| stackTrace: "remote stack trace line 1\nline 2"); | ||
| Assert.Equal("remote stack trace line 1\nline 2", ex.StackTrace); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void StackTraceDefaultsToRuntimeTrace() | ||
| { | ||
| var ex = new HandlerException(HandlerErrorType.Internal, "fail"); | ||
| // Not thrown, so runtime stack trace is null | ||
| Assert.Null(ex.StackTrace); | ||
| } |
There was a problem hiding this comment.
Worth considering adding cases around how the override works when the exceptions are thrown. I.E. override is still used when thrown and runtime trace not null when thrown with no override provided.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.