Skip to content

stop responding with "..." - #1491

Merged
clark-cant merged 1 commit into
nextlevelbuilder:devfrom
bilogic:dev
Aug 2, 2026
Merged

stop responding with "..."#1491
clark-cant merged 1 commit into
nextlevelbuilder:devfrom
bilogic:dev

Conversation

@bilogic

@bilogic bilogic commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Summary

Type

  • Feature
  • Bug fix
  • Hotfix (targeting main)
  • Refactor
  • Docs
  • CI/CD

Target Branch

Checklist

  • go build ./... passes
  • go build -tags sqliteonly ./... passes (if Go changes)
  • go vet ./... passes
  • Tests pass: go test -race ./...
  • Web UI builds: cd ui/web && pnpm build (if UI changes)
  • No hardcoded secrets or credentials
  • SQL queries use parameterized $1, $2 (no string concat)
  • New user-facing strings added to all 3 locales (en/vi/zh)
  • Migration version bumped in internal/upgrade/version.go (if new migration)

Test Plan

chatting with LLM over telegram

@clark-cant

Copy link
Copy Markdown
Contributor

⚠️ Duplicate overlap detected

This PR overlaps materially with #1116 by @nguyennguyenit (opened 2026-05-07):

  • Title: fix(agent): suppress empty final content instead of sending literal "..."
  • Same root problem: bot sends literal "..." to users when LLM produces empty final content
  • Same files touched: loop_finalize.go, finalize_stage.go

Key differences:

#1116 #1491 (this)
Base branch main ❌ dev ✓
Merge state DIRTY (conflicts) UNSTABLE (CI pending)
Approach Suppress delivery (no message) Replace with localized i18n warning
Retry nudge No Yes (bounded, max 2)
Tests 3 cases 14 cases
Last active 2026-06-26 2026-08-01

Maintainer decision needed: These two PRs cannot both be merged — they modify the same fallback logic with incompatible approaches. Please indicate which direction to take:

  1. Suppress delivery (fix(agent): suppress empty final content instead of sending literal "..." #1116 approach) — close this PR, revive fix(agent): suppress empty final content instead of sending literal "..." #1116 with rebase to dev
  2. Localized warning + retry (this PR) — merge this, close fix(agent): suppress empty final content instead of sending literal "..." #1116 as superseded

This PR is more comprehensive and correctly targets dev, but #1116 was first. Flagging for maintainer triage.

Posted by github-maintain cron at 2026-08-02T00:00:00Z

@clark-cant clark-cant left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Clean fix replacing the bare "..." placeholder with a localized i18n fallback message.

Review summary:

  • ✅ Correctness: Properly replaces "..." in both loop_finalize.go and finalize_stage.go with i18n.T() call
  • ✅ i18n: All 3 locales (en/vi/zh) have meaningful fallback messages
  • ✅ ThinkStage nudge: Bounded (max 2 retries), correctly skips on last iteration and media-only runs
  • ✅ Tests: 12+ test cases covering nudge, break, media-only, silent, locale paths
  • ✅ CI: All 3 checks pass (go, web, release-versioning)
  • ✅ Merge state: CLEAN, targets dev

Good improvement to UX — users will now get a meaningful message instead of cryptic "...".

@clark-cant
clark-cant merged commit 6e61bd1 into nextlevelbuilder:dev Aug 2, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants