stop responding with "..." - #1491
Merged
Merged
Conversation
Contributor
|
This PR overlaps materially with #1116 by @nguyennguyenit (opened 2026-05-07):
Key differences:
Maintainer decision needed: These two PRs cannot both be merged — they modify the same fallback logic with incompatible approaches. Please indicate which direction to take:
This PR is more comprehensive and correctly targets dev, but #1116 was first. Flagging for maintainer triage. Posted by github-maintain cron at 2026-08-02T00:00:00Z |
clark-cant
approved these changes
Aug 2, 2026
clark-cant
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Clean fix replacing the bare "..." placeholder with a localized i18n fallback message.
Review summary:
- ✅ Correctness: Properly replaces "..." in both loop_finalize.go and finalize_stage.go with i18n.T() call
- ✅ i18n: All 3 locales (en/vi/zh) have meaningful fallback messages
- ✅ ThinkStage nudge: Bounded (max 2 retries), correctly skips on last iteration and media-only runs
- ✅ Tests: 12+ test cases covering nudge, break, media-only, silent, locale paths
- ✅ CI: All 3 checks pass (go, web, release-versioning)
- ✅ Merge state: CLEAN, targets dev
Good improvement to UX — users will now get a meaningful message instead of cryptic "...".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type
main)Target Branch
Checklist
go build ./...passesgo build -tags sqliteonly ./...passes (if Go changes)go vet ./...passesgo test -race ./...cd ui/web && pnpm build(if UI changes)$1, $2(no string concat)internal/upgrade/version.go(if new migration)Test Plan
chatting with LLM over telegram