Nr 370484 fb metrics (#2033) #2034
Conversation
* feat: Updated Fb metrics by default * feat: Updated test cases * feat:Updated host details * feat: Updated test cases and scrape interval
Pull Request Test Coverage Report for Build 14462832288Details
💛 - Coveralls |
| flag == FlagDmRegisterDeprecated || | ||
| flag == FlagFullInventoryDeletion | ||
| flag == FlagFullInventoryDeletion || | ||
| flag == FlagFluentBitMetrics |
There was a problem hiding this comment.
How does this feature flag work? At what stage its being used? During installation?
There was a problem hiding this comment.
Right now this works on start of agent , so on every FF change we need to restart the Agent. Let me check if there is a way to not restart
pkg/integrations/v4/logs/cfg.go
Outdated
| MetricsPath: "/api/v2/metrics/prometheus", | ||
| ScrapeInterval: "60s", |
maya-jha
left a comment
maya-jha
left a comment
There was a problem hiding this comment.
- Please provide details about how changes were tested.
- Any changes in default logging.yml?
- What changes will be required to get it working with super agent?
- Here option to turn off metrics would be more important as there is no way to update this.
- Have you looked at health check options. Can this be useful in future ?https://docs.fluentbit.io/manual/administration/monitoring#health-check-for-fluent-bit
pkg/integrations/v4/logs/cfg.go
Outdated
| var fbOSConfig FBOSConfig | ||
| addOSDependantConfig(&fbOSConfig) | ||
|
|
||
| enableMetrics := isMetricsEnabled(ff) |
There was a problem hiding this comment.
Will user have option to turn it off? Do we have PM alignment on this if we are not offering the ability to turn it off?
There was a problem hiding this comment.
Yes. we has a alignment with PM
cc: @nr-rkallempudi
| Log_Level {{ .LogLevel }} | ||
| {{- end }} | ||
| {{- if .Daemon }} | ||
| Daemon {{ .Daemon }} | ||
| {{- end }} | ||
| {{- if .ParsersFile }} | ||
| Parsers_File {{ .ParsersFile }} | ||
| {{- end }} | ||
| {{- if .HTTPServer }} | ||
| HTTP_Server {{ .HTTPServer }} | ||
| {{- end }} | ||
| {{- if .HTTPListen }} | ||
| HTTP_Listen {{ .HTTPListen }} | ||
| {{- end }} | ||
| {{- if .HTTPPort }} | ||
| HTTP_Port {{ .HTTPPort }} | ||
| {{- end }} |
There was a problem hiding this comment.
from where we are getting these values?
| // Newrelic OUTPUT plugin will send all the collected logs to Vortex | ||
| fb.Output = newNROutput(logFwdCfg) | ||
| // Including Prometheus scrapper input plugin by default to pull Fluent bit metrics based on ff | ||
| includePrometheusScrapperInputPlugin(&fb, enableMetrics) |
There was a problem hiding this comment.
Are we planning to send all metrics? What are the cost implications here?
There was a problem hiding this comment.
Yes. We are planning to send all the metrics. Will share the Cost analysis doc
|
@maya-jha 1. Please provide details about how changes were tested. |
This PR includes Fluentbit metrics forwarder in the default IA based on feature flag : "fluent_bit_metrics"
For more details please refer jira: https://new-relic.atlassian.net/browse/NR-370484