Fixed issue on temporary folder#169
Open
kreamweb wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes unreliable behavior around the editor chat temporary upload directory (
uploads/nfd-chat-temp/), which is used by POST /nfd-editor-chat/v1/upload and read by MCP DocumentRead.Problems addressed
nfd-chat-temp/was only created on the first successful upload, so consumers (e.g. MCP document read via realpath()) could fail when the directory did not exist yet.Upload validation relied on the browser-reported MIME type ($file['type']), which is often application/octet-stream for .csv, .md, and .pdf on production hosts.
ChatEditor was only bootstrapped when Permissions::is_editor() was true at plugins_loaded, so REST routes were not registered in some request contexts.
Changes
Production
Development
Visual
Checklist
Further comments