PRESS0-4271 Add PHP syntax check (php -l) to CI workflows for all PHP files

[vikasrana1998]

Proposed changes

Type of Change

Production

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Dependency update
• Refactoring / housekeeping (changes to files not directly related to functionality)

Development

• Tests
• Dependency update
• Environment update / refactoring
• Documentation Update

Visual

Checklist

• I have read the CONTRIBUTING doc
• I have viewed my change in a web-browser
• Linting and tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

Further comments

[Copilot]

Pull request overview

Adds a reusable GitHub Actions workflow to run php -l against PHP files, enabling PHP syntax validation in CI for repositories that call this workflow.

Changes:

• Introduces a new reusable workflow (workflow_call) for PHP syntax linting with configurable PHP version.
• Implements scope logic to lint either PR-changed PHP files (default on PRs) or all PHP files (default otherwise).
• Adds path-prefix exclusions via a paths-ignore input to avoid linting dependency directories (e.g., vendor, node_modules).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[github-actions]

AI code review

✅ Strengths

• Pinned action SHAs and least-privilege permissions are well done (top-level permissions: {}, job-level contents: read) — great security posture.
• Sensible, composable inputs with clear defaults (php-version, scope auto/changed/all, paths-ignore, timeout) make this easy to adopt across repos.
• Robust scope resolution with graceful fallbacks: auto → changed when PR SHAs are present, otherwise all; proper fallback to all when SHAs are missing or merge-base/diff fails, with helpful ::notice messages.
• Good file handling hygiene: safe Bash (set -euo pipefail), mapfile usage, quoting, and explicit filtering/validation of candidate paths.
• Per-file annotations with parsed line numbers and careful escaping of workflow command values/properties — this will make failures actionable in the UI.
• Summaries improve DX by showing scope, counts, and an optional file list.
• Ignores vendor/node_modules by default and re-applies ignore filtering even in changed scope — avoids false positives.

⚠️ Suggestions (non-blocking)

• Consider parallelizing php -l to speed up large repos, e.g. xargs -P"$(nproc)" php -l, while preserving per-file annotations (you could collect failures and then emit annotations after the parallel run).
• For the all scope, consider using git ls-files to enumerate tracked PHP files instead of find. This respects sparse checkouts and is often faster and simpler to maintain. Example: git ls-files -z -- ':(icase,glob)**/*.php' | tr '\0' '\n'.
• Consider supporting additional common PHP-related extensions via an input (e.g., .phtml, .inc, .php5) so callers can opt-in when needed.
• Optional: cap the “File list” in the step summary (e.g., first 500) and show a count beyond that, to avoid massive summaries on very large repos.
• Minor readability: the checkout fetch-depth expression could be made more explicit (or a separate step var) to avoid string-vs-number ambiguity and improve clarity for future readers.
• Minor: when computing changed files you already derive merge_base; using a two-dot diff (merge_base..HEAD) or directly diffing BASE...HEAD without precomputing merge-base would be simpler and less surprising than mixing an explicit merge-base with a triple-dot diff.
• Minor log noise: after emitting ::error annotations, also echoing the full php -l output duplicates information. Consider keeping the log file + summary but skipping the extra echo to reduce clutter.

❌ Issues (blocking/critical)

• None identified. The workflow is secure-by-default, robust to common edge cases, and failure modes are well surfaced. Any items above are polish/performance/readability and not merge blockers.

Verdict

⚠️ Verdict: Solid addition that meaningfully improves CI safety for PHP code. Recommend merge with the minor follow-ups above as subsequent polish.

---

Automation note: This AI review is posted as one regular pull-request conversation comment and will be updated in place on each successful workflow run. It does not create or dismiss formal GitHub Reviews.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.