-
Notifications
You must be signed in to change notification settings - Fork 26
Add durations to pytest in CI. #635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Oh, somehow I didn't realise, all tests are much slower on python 3.13.
|
|
Times from the tests on Windows (slowest OS) 3.9 are below.
Total test time is 44 minutes. I think some obvious areas for improvement are:
I think 2) and 3) might be unavoidable, with the only way to reduce this reducing the scope of what's tested. I'd rather have them tested somewhere, the options being:
I think (1) is best, if most development is occuring on draft PRs and we can get these down to < 10 minutes (still quite long) then that shouldn't hammer the CI too badly. Better to accidentally run the full test suite when you don't really need to rather than not run it when you should. |
|
Same issue for python 3.12, will cancel tests as they are obviously taking much longer. Trying to revert the pre-commit PR though I can't see how that would cause this |
|
Changing the pre-commit did not help, of course. Try reverting to the PR before this happened. |
6c199c2 to
5708459
Compare
eaaabbe to
a3f9ce9
Compare
|
Current hypothesis is that some dependency updated when the tests started taking longer, and it only affected python 3.9+ but not python 3.9 |
|
Okay great that was it, a fancylog update included subprocess calls, didn't clock at the time these will be slow. Also try removing codecov just to see if that has much of an affect on test times, as I read it could. |
Windows tests for python 3.13 are taking a very long time to run, #631. This PR prints the time taken for every test to dig further int othis.
The issue really started after this PR which is just a pre-commit auto update. Will try downgrading these.