-
Notifications
You must be signed in to change notification settings - Fork 118
Improvements to isomorphism tutorial. #141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Fine as long as tight_layout is last call in cell.
eriknw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good to me. I like using explicit axes and figures in matplotlib instead of relying on pyplot implicit API.
I left one tiny typo suggestion. There were places where I would consider adding a comma, but I don't like being a comma-nazi :-P
Co-authored-by: Erik Welch <[email protected]>
dschult
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In reading through this file, I notice that line 252 should either remove the word "that" or add "are isomorphic" at the end of the line.
Also, on line 58, I think the bijection for the example would be the identity isomorphism. And not f(i) = i+1 as stated.
Perhaps we should pick an example where it is easy (in code) to get differently named nodes. For example, G = nx.wheel_graph(8) and H = nx.wheel_graph(range(1,9)). But maybe the drawings of those networks are not as nice. But the incorrect mapping is confusing as it is.
Co-authored-by: Dan Schult <[email protected]>
Minor touchups to the isomorphism notebook.
I've limited the changes in this PR to minor changes in wording, line formatting (i.e. splitting up very long lines, where possible), and minor touchups to links etc.
LMK what you think!