Update from update/networkservicemesh/cmd-nse-vlan-vpp - #13842
Merged
Conversation
…d-nse-vlan-vpp@main PR link: networkservicemesh/cmd-nse-vlan-vpp#630 Commit: cbe3dd8 Author: Botond Szirtes Date: 2026-09-07 15:39:16 +0200 Message: - Pin go.fd.io/govpp to v0.11.0 to avoid Unsubscribe regression (#630) govpp v0.13.0 leaves a closed notification channel in Connection.subscriptions, so the next notification panics with "send on closed channel". subscriptionCtx.Unsubscribe() swap-removes the subscription from a local slice variable and never stores the shrunk slice back into conn.subscriptions[msgID]. With a single subscription the bug is masked because the map entry is deleted when the local slice reaches length 0. With two or more subscriptions for the same message id the map keeps its original length and still references the subscription whose notifChan was just closed. sdk-vpp subscribes to interfaces.SwInterfaceEvent per connection (up, ipsecup, peerup, memifrxmode, heal/liveness_check), so any component serving more than one connection can hit it. No module requires v0.13.0: vpphelper and networkservicemesh/govpp require v0.11.0 and sdk-vpp requires v0.10.0-alpha. The uplift came from the update bot running 'go get -u vpphelper@main', which upgrades the named package's whole dependency closure. Follows networkservicemesh/cmd-forwarder-vpp#1359. Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
bszirtes
self-requested a review
September 7, 2026 13:44
bszirtes
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update go.mod and go.sum to latest version from networkservicemesh/cmd-nse-vlan-vpp@main
PR link: networkservicemesh/cmd-nse-vlan-vpp#630
Commit: cbe3dd8
Author: Botond Szirtes
Date: 2026-09-07 15:39:16 +0200
Message:
govpp v0.13.0 leaves a closed notification channel in Connection.subscriptions, so the next notification panics with "send on closed channel".
subscriptionCtx.Unsubscribe() swap-removes the subscription from a local slice variable and never stores the shrunk slice back into conn.subscriptions[msgID]. With a single subscription the bug is masked because the map entry is deleted when the local slice reaches length 0. With two or more subscriptions for the same message id the map keeps its original length and still references the subscription whose notifChan was just closed.
sdk-vpp subscribes to interfaces.SwInterfaceEvent per connection (up, ipsecup, peerup, memifrxmode, heal/liveness_check), so any component serving more than one connection can hit it.
No module requires v0.13.0: vpphelper and networkservicemesh/govpp require v0.11.0 and sdk-vpp requires v0.10.0-alpha. The uplift came from the update bot running 'go get -u vpphelper@main', which upgrades the named package's whole dependency closure.
Follows networkservicemesh/cmd-forwarder-vpp# 1359.