x86: fix {er} decorator placement for integer-source VCVT* instructions#229
Open
thac0 wants to merge 1 commit intonetwide-assembler:masterfrom
Open
x86: fix {er} decorator placement for integer-source VCVT* instructions#229thac0 wants to merge 1 commit intonetwide-assembler:masterfrom
thac0 wants to merge 1 commit intonetwide-assembler:masterfrom
Conversation
For `VCVTUSI2SD`, `VCVTUSI2SS`, and `VCVTUSI2SH`, the `|er` flag in
`insns.dat` was attached to the XMM pass-through source (operand 2, the
vvvv field) rather than the integer source (operand 3, the rm field).
This caused NASM to require the embedded-rounding decorator before the
integer register rather than after it, which is wrong; the correct
syntax is `vcvtusi2ss xmm0,xmm1,eax,{rn-sae}`, not `vcvtusi2ss
xmm0,xmm1,{rn-sae},eax`.
Move `|er` to the integer source operand for all six affected entries,
and change the XMM source from `xmmreg|er` to `xmmreg*` (optional
duplicate of the destination, consistent with every other scalar
integer-to-float convert in the file).
Also fix a copy-paste error in `insns.dat` where the second `VCVTUSI2SH`
entry (W=1, rm64) was mis-labeled as `VCVTUSI2SS`.
Update `travis/test/avx512f.asm` to use the correct decorator syntax
(`reg,{rN-sae}` instead of `{rN-sae},reg`) for the ER forms of
`VCVTSI2SD`, `VCVTSI2SS`, `VCVTUSI2SD`, and `VCVTUSI2SS`; regenerate the
golden `avx512f.bin.t`. The encoded bytes are unchanged.
`travis/test/avx512f.json` had a trailing comma after the last field of
the JSON object, making it invalid JSON. Remove the trailing comma.
Signed-off-by: Joe Konno <joe.konno@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For
VCVTUSI2SD,VCVTUSI2SS, andVCVTUSI2SH, the|erflag ininsns.datwas attached to the XMM pass-through source (operand 2, the vvvv field) rather than the integer source (operand 3, the rm field). This caused NASM to require the embedded-rounding decorator before the integer register rather than after it, which is wrong; the correct syntax isvcvtusi2ss xmm0,xmm1,eax,{rn-sae}, notvcvtusi2ss xmm0,xmm1,{rn-sae},eax.Move
|erto the integer source operand for all six affected entries, and change the XMM source fromxmmreg|ertoxmmreg*(optional duplicate of the destination, consistent with every other scalar integer-to-float convert in the file).Also fix a copy-paste error in
insns.datwhere the secondVCVTUSI2SHentry (W=1, rm64) was mis-labeled asVCVTUSI2SS.Update
travis/test/avx512f.asmto use the correct decorator syntax (reg,{rN-sae}instead of{rN-sae},reg) for the ER forms ofVCVTSI2SD,VCVTSI2SS,VCVTUSI2SD, andVCVTUSI2SS; regenerate the goldenavx512f.bin.t. The encoded bytes are unchanged.travis/test/avx512f.jsonhad a trailing comma after the last field of the JSON object, making it invalid JSON. Remove the trailing comma.