Skip to content

nasmtok.el: Excesive quoting in definition of nasm-token-lists #231

Description

@8dcc

The editors/nasmtok.pl script is used to generate editors/nasmtok.el. One of the variables generated by the script is nasm-token-lists, which should contain a list of symbols, each one being the name of a previously defined list.

This is the current definition:

(defconst nasm-token-lists
  '('nasm-decorator 'nasm-directive 'nasm-instruction 'nasm-mmacro
    'nasm-operator 'nasm-pp-directive 'nasm-prefix 'nasm-register 'nasm-size
    'nasm-smacro 'nasm-special 'nasm-special-constant)
  "List of all NASM 3.02rc7 token type lists.")

The bug is that, since the outer list is already quoted, there is no need to quote each symbol inside it. Right now, the variable evaluates to:

((quote nasm-decorator)
 (quote nasm-directive)
 (quote nasm-instruction)
 (quote ...))

The fix is to generate the variable as:

(defconst nasm-token-lists
  '(nasm-decorator nasm-directive nasm-instruction nasm-mmacro
    nasm-operator nasm-pp-directive nasm-prefix nasm-register nasm-size
    nasm-smacro nasm-special nasm-special-constant)
  "List of all NASM 3.02rc7 token type lists.")

The nasmtok.el file was generated with the nasmtok.pl script at commit aa12d33.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions