Skip to content

Conversation

@benmccann
Copy link
Contributor

@benmccann benmccann commented Jul 24, 2025

🎉 Thanks for submitting a pull request! 🎉

Summary

Upgrades to the latest


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures
    we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
    something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures
    your code follows our style guide and passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

Copy link
Member

@serhalp serhalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

"@netlify/binary-info": "^1.0.0",
"@netlify/serverless-functions-api": "^2.1.3",
"@vercel/nft": "0.29.4",
"@vercel/nft": "^0.30.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC we had pinned this because of vercel/nft#457. I think unpinning is fine now 🤷🏼.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great! thank you for confirming. that does indeed look to be resolved now

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI we ended up needing to revert this: #6610. It caused a regression with function bundling on node 22 due to something added in vercel/nft#534. Specifically this resulted in the ./dist/node-fetch-server.js file not ending up included in the bundle. We haven't dug any further than that at the moment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's funny it only affects this repo. I can't find any issues for it in the vercel/nft repo. If you get a chance to investigate a bit it might be worth filing an issue there

@serhalp serhalp merged commit 6a73261 into netlify:main Jul 24, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants