fix(auth): add timeout to login backend HTTP client#52
Open
edospadoni wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
http.Clientused inmiddleware/middleware.goto forward/loginrequests to the legacy NetCTI backend was created with noTimeout. If the backend leaves the response unfinished (for example an unhandled exception path that never writes a status line and never closes the connection), the call toclient.Do(req)will block indefinitely.In practice this means the goroutine handling the login stays parked and the underlying TCP connection to the backend is kept open with no upper bound, in some cases for days.
All other
http.Clientinstances in this repository already set aTimeout(seemethods/auth.go,methods/history.go,methods/voicemail.go,methods/proxy.go,store/persistence.go); this change restores consistency by settingTimeout: 30 * time.Secondon the login client as well.