fix: correct optional peer dependencies#1238
Closed
alumni wants to merge 1 commit intonest-modules:mainfrom
Closed
fix: correct optional peer dependencies#1238alumni wants to merge 1 commit intonest-modules:mainfrom
alumni wants to merge 1 commit intonest-modules:mainfrom
Conversation
Author
|
@juandav Could you please review? Thank you :) |
kelvinmenegasse
approved these changes
Dec 13, 2024
rlcDev
approved these changes
Dec 19, 2024
schuerg
approved these changes
Mar 26, 2025
juandav
added a commit
that referenced
this pull request
Mar 21, 2026
- fix(service): use logger.log instead of debug for transporter ready message (#1239, #1248, #1249) - fix(service): reuse createTransporter in addTransporter for consistent verification and hooks (#1234) - fix(liquid): initialize config with default empty object to prevent TypeError (#1232) - fix(mjml): add optional chaining for others param to prevent crash when undefined - fix(deps): add peerDependenciesMeta to mark template engines as optional (#1238, #1244) - fix(deps): move tslib from devDependencies to dependencies for PnP runtime support (#1230) - chore(deps): update devDependencies to latest compatible versions (#1242, #1250) - docs: add Liquid adapter examples, MJML clarifications, multi-transporter docs (#1246) - docs: add pnpm installation instructions and liquidjs to README Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
juandav
added a commit
that referenced
this pull request
Mar 21, 2026
- fix(service): use logger.log instead of debug for transporter ready message (#1239, #1248, #1249) - fix(service): reuse createTransporter in addTransporter for consistent verification and hooks (#1234) - fix(liquid): initialize config with default empty object to prevent TypeError (#1232) - fix(mjml): add optional chaining for others param to prevent crash when undefined - fix(deps): add peerDependenciesMeta to mark template engines as optional (#1238, #1244) - fix(deps): move tslib from devDependencies to dependencies for PnP runtime support (#1230) - chore(deps): update devDependencies to latest compatible versions (#1242, #1250) - docs: add Liquid adapter examples, MJML clarifications, multi-transporter docs (#1246) - docs: add pnpm installation instructions and liquidjs to README Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Member
|
Superseded by branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently optional peer dependencies are not declared correctly, they are declared twice: as mandatory peer dependencies as well as optional direct dependencies.
This often causes false positives during security scans. E.g.:
preview-emailis not needed in production, however it has often been the cause of failing security audits.This PR aims to declare them according to the package.json spec, i.e. using
peerDependenciesMeta. This is available sincenpm@6.11(August 2019), so any package manager in use nowadays should be able to handle this:With this change, apps relying on
@nestjs-modules/mailerwill be able to avoid installing some of these optional peer dependencies if they are not needed (e.g. viapnpm.ignoredOptionalDependencies).