Skip to content

FEATURE: introduce 404 document #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

FEATURE: introduce 404 document #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fbd6d99
FEATURE: introduce 404 document
crydotsnake Sep 15, 2023
64b77ab
TASK: add node migration for change document nodetype
crydotsnake Sep 15, 2023
68ea28b
TASK: use new 404 document in flow query
crydotsnake Sep 15, 2023
9f46f2f
TASK: only allow text element on 404 page
crydotsnake Sep 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions DistributionPackages/Neos.DocsNeosIo/Migrations/ContentRepository/Version20230915114256.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
up:
comments: 'Changes the NodeType of the Page not found page to the newly introduced 404 document type'
migration:
-
filters:
-
type: NodeName
settings:
nodeName: 'Page not found'
transformations:
-
type: ChangeNodeType
settings:
newType: Neos.DocsNeosIo:Document.404


down:
comments: 'No down migration available'
25 changes: 25 additions & 0 deletions DistributionPackages/Neos.DocsNeosIo/NodeTypes/Document/404.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
'Neos.DocsNeosIo:Document.404':
search:
fulltext:
enable: false
childNodes:
main:
type: 'Neos.Neos:ContentCollection'
constraints:
nodeTypes:
'*': false
'Neos.DocsNeosIo:Content.Text': true

superTypes:
'Neos.Neos:Document': true
'Neos.Seo:NoindexMixin': true
'Neos.DocsNeosIo:Mixin.HideSeo': true
ui:
label: '404'
icon: 'fas fa-exclamation-triangle'
properties:
_hiddenInIndex:
defaultValue: true
ui:
inspector:
group: null
11 changes: 11 additions & 0 deletions DistributionPackages/Neos.DocsNeosIo/Resources/Private/Fusion/Document/404/404.fusion
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
prototype(Neos.DocsNeosIo:Document.404) < prototype(Neos.DocsNeosIo:Document.AbstractPage) {
body.navCollection = ${q(node).find('main').children()}
body.content = Neos.Fusion:Component {
main = Neos.Neos:ContentCollection {
nodePath = 'main'
}
renderer = afx`
{props.main}
`
}
}
2 changes: 1 addition & 1 deletion DistributionPackages/Neos.DocsNeosIo/Resources/Private/Fusion/Error/NotFound.fusion
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# for exceptions with 4xx status code
#
error {
@context.notfoundDocument = ${q(site).children('[uriPathSegment = "404"]').get(0)}
@context.notfoundDocument = ${q(site).find('[instanceof Neos.DocsNeosIo:Document.404]').get(0)}

4xx {
@position = 'start'
Expand Down
11 changes: 11 additions & 0 deletions ...onPackages/Neos.DocsNeosIo/Resources/Private/Translations/de/NodeTypes/Mixin/MenuItem.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<?xml version="1.0"?>
<xliff version="1.2" xmlns="urn:oasis:names:tc:xliff:document:1.2">
<file original="" product-name="Neos.DocsNeosIo" source-language="en" target-language="de" datatype="plaintext">
<body>
<trans-unit id="properties.hideFromMainMenu">
<source>Hide from main menu</source>
<target>Im Hauptmenü verstecken</target>
</trans-unit>
</body>
</file>
</xliff>
10 changes: 10 additions & 0 deletions ...onPackages/Neos.DocsNeosIo/Resources/Private/Translations/en/NodeTypes/Mixin/MenuItem.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<?xml version="1.0"?>
<xliff version="1.2" xmlns="urn:oasis:names:tc:xliff:document:1.2">
<file original="" product-name="Neos.DocsNeosIo" source-language="en" datatype="plaintext">
<body>
<trans-unit id="properties.hideFromMainMenu">
<source>Hide from main menu</source>
</trans-unit>
</body>
</file>
</xliff>