Skip to content

Fix authorization in create #6801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 6, 2025
Merged

Fix authorization in create #6801

merged 3 commits into from
Nov 6, 2025

Conversation

@angrykoala
Copy link
Member

@angrykoala angrykoala commented Nov 5, 2025

No description provided.

@angrykoala angrykoala linked an issue Nov 5, 2025 that may be closed by this pull request
Variable this0 not defined on create with authorization #6797
Closed
@changeset-bot
Copy link

changeset-bot bot commented Nov 5, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 73a57ef

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@angrykoala angrykoala force-pushed the 6797-variable-this0-not-defined-on-create-with-authorization branch 2 times, most recently from 3203b2c to 5c1888b Compare November 5, 2025 14:31
@angrykoala angrykoala marked this pull request as ready for review November 5, 2025 14:32
@angrykoala angrykoala force-pushed the 6797-variable-this0-not-defined-on-create-with-authorization branch from 5c1888b to ff6b4c6 Compare November 5, 2025 14:36
@neo4j-team-graphql
Copy link
Collaborator

neo4j-team-graphql commented Nov 5, 2025 •
edited
Loading

Performance Report

No Performance Changes

Show Full Table
name dbHits old dbHits time (ms) old time (ms) maxRows
aggregations.TopLevelAggregateWithMultipleFields 7936 7936 55 79 1134
aggregations.NestedAggregation 15407 15407 65 95 2174
aggregations.AggregationWithWhere 10833 10833 45 68 2174
aggregations.AggregationWhereWithinNestedRelationships 20097917 20097917 1939 2069 2008534
aggregations.AggregationWhereWithinNestedConnections 20097917 20097917 1958 1973 2008534
aggregations.InterfacesAggregations 8324 8324 94 124 2080
aggregations.InterfacesAggregationsWithTwoFields 13526 13526 126 256 2080
connections.Connection 12951 12951 173 82 2174
connections.NestedConnection 37705 37705 123 132 4516
connections.totalCount 1 1 17 24 1
cypher-directive-mutation.TopLevelMutationDirective 1135 1135 24 37 1134
cypher-directive.TopLevelSortWithCypher 12961 12961 42 49 2174
cypher-directive.TopLevelConnectionSortWithCypher 12961 12961 60 75 2174
cypher-directive.TopLevelSortWithCypherWithNested 13096 13096 61 74 2174
cypher-directive.TopLevelConnectionSortWithCypherWithNested 13096 13096 90 110 2174
cypher-directive.TopLevelSortWithExpensiveCypher 13725 13725 104 145 2174
cypher-directive.TopLevelConnectionSortWithExpensiveCypher 13266 13266 98 167 2174
fulltext.Fulltext 80 80 45 52 16
fulltext.FulltextWithNestedQuery 516 516 62 77 84
1262.NestedConnectionWhere 8703 8703 51 69 2174
187.QueryWhere 8564 8564 34 47 2154
2871.NestedRelationshipFilter 19632 19632 61 75 4395
batch-create.BatchCreate 3600 3600 91 102 600
connect.createAndConnect 4410 4410 52 68 1134
create.SimpleMutation 6 6 32 35 1
delete.SimpleDelete 19401 19401 686 687 1040
delete.NestedDeleteInUpdate 14688 14688 108 141 1179
update.NestedUpdate 10129 10129 61 87 2002
query.SimpleQuery 3121 3121 22 25 1040
query.SimpleQueryWithRelationship 15031 15031 48 59 2174
query.SimpleQueryWithNestedWhere 8713 8713 50 66 2154
query.Nested 3988 3988 78 86 1040
query.OrFilterOnRelationships 36730 36496 160 185 1955
query.OrFilterOnRelationshipsAndNested 26719 26531 210 226 1955
query.QueryWithNestedIn 14192 14189 56 65 1864
query.DeeplyNestedConnectionWhere 8702 8702 76 95 2174
query.DeeplyNestedWithRelationshipFilters 17357 17357 135 165 1552
query.NestedWithRelationshipSingleFilters 3808 3808 157 213 1134
sorting.SortMultipleTypes 3436 3436 78 87 1040
sorting.SortMultipleTypesWithCypherWithCypher 13321 13321 97 121 2174
sorting.SortOnNestedFields 12951 12951 49 54 2174
sorting.SortDeeplyNestedFields 39785 39785 90 112 4516
sorting.ConnectionWithSort 3271 3271 72 79 1040
unions.SimpleUnionQuery 321 321 58 61 35
unions.SimpleUnionQueryWithMissingFields 293 293 56 69 35
unions.NestedUnion 309975 309975 253 274 33033
unions.NestedUnionWithMissingFields 283949 283949 254 264 33033

Old Schema Generation: 22.768s
Schema Generation: 22.314s
Old Subgraph Schema Generation: 25.632s
Subgraph Schema Generation: 26.049s

@angrykoala angrykoala force-pushed the 6797-variable-this0-not-defined-on-create-with-authorization branch 2 times, most recently from 6455f8b to eb194db Compare November 5, 2025 16:49
@angrykoala angrykoala force-pushed the 6797-variable-this0-not-defined-on-create-with-authorization branch from eb194db to 2da1acd Compare November 5, 2025 16:55
a-alle
a-alle previously approved these changes Nov 5, 2025
View reviewed changes
packages/graphql/src/translate/queryAST/ast/operations/CreateOperation.ts Outdated
Comment on lines 183 to 192
return [Cypher.utils.concat(...subqueries, new Cypher.With("*"), ...selections, ...validations)];
}
return [...subqueries, new Cypher.With("*").where(predicate), ...selections, ...validations];
return [
Cypher.utils.concat(
...subqueries.map((sq) => new Cypher.Call(sq, "*")),
new Cypher.With("*").where(predicate),
...selections,
...validations
),
];
Copy link
Contributor

@a-alle a-alle Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought we concluded there's no selections and predicates for Create auth

Copy link
Member Author

@angrykoala angrykoala Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, that was in the other branch and I forgot to port it to this one

packages/graphql/src/translate/queryAST/ast/operations/TopLevelCreateMutationOperation.ts Outdated
}
const subqueries = this.createOperations.map((field) => {
const { clauses, projectionExpr } = field.transpile(context);
const oprationQueries = this.topLevelCreateOperations.map((createOperation) => {
Copy link
Contributor

@a-alle a-alle Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

@angrykoala angrykoala merged commit dcd1998 into dev Nov 6, 2025
46 checks passed
@angrykoala angrykoala deleted the 6797-variable-this0-not-defined-on-create-with-authorization branch November 6, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@a-alle a-alle a-alle left review comments

@MacondoExpress MacondoExpress Awaiting requested review from MacondoExpress

Assignees

No one assigned

Labels

graphql

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Variable this0 not defined on create with authorization

4 participants

@angrykoala @neo4j-team-graphql @a-alle