Repository navigation
Describe sbs96_compare.py as it is: stdlib-only, kept untested - #820
Merged
Merged
Conversation
CLAUDE.md and the compare_af header said it parses SigProfiler output, which was the stated reason it stays Python. It reads a FASTA and two VCFs and needs no external tool. It produced the #372 HCC1395 cosine figure and has no current caller; it stays as is, with tests added only if it is needed again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLAUDE.md and the
eidolon/src/compare_af/mod.rsheader both saidscripts/delta/sbs96_compare.pyparses SigProfiler's output, and CLAUDE.md gave that as the one justification for keeping it in Python. The script uses only the Python standard library: it reads a FASTA and two VCFs and computes the SBS-96 cosine itself.Both descriptions now say what it does, that it produced the HCC1395 0.72 → 0.99 figure (#372), and that it has no current caller. Decision (2026-10-06): keep it as is, untested. Tests get added if it is needed again; otherwise it goes when the validation scripts are archived.
Comment and docs only. No behavior change, no version impact.
Covers item 6 of #819.
🤖 Generated with Claude Code