Repository navigation
fix(dispatch): keep notebook tasks owned and coverage warnings actionable - #53
Merged
Merged
Conversation
Keep unresolved-only probe uncertainty visible in explain without warning on accepted calls; expose explicit warn and strict policies while retaining warnings for analysis limits. Reject captured live asyncio resources at core and generic transport boundaries, and cancel pending work before attempting running cancellation on an interrupted blocking dispatch. Add repeated real-kernel publication, query, task-ownership, and interrupt-liveness regression coverage with a dedicated notebook CI job. Verified with focused suites and the good-enough representative suite. The historical indefinite Store/query stall remains unassigned without its interrupt traceback.
Wait for a worker-start marker so the real-kernel check does not signal before the dispatched call begins. Accept ipykernel's delivered KeyboardInterrupt or normal completion when it signals its loop thread, and require matching publication counts and surviving kernel tasks in either case.\n\nVerification: focused real-kernel notebook test and targeted lint passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dispatch.explain()without warning on successful notebook dispatch by default; add explicit warn and strict policies.Fixes #49 to our knowledge. If the warning or kernel-task symptom remains reproducible after merging, reopen the issue with a fresh traceback. The historically observed Store/query stall is not claimed fixed by this change.
Verification
Post-Deploy Monitoring & Validation
dispatch.runand inspect cell output forTask was destroyed,Kernel.shell_main, andDispatchCoverageWarning.dispatch.explain()retains coverage diagnostics. Reopen Suppress spurious ipykernel task and coverage warnings during notebook dispatch #49 on recurrence.