Repository navigation
fix(core): make mapping identity order-independent - #52
Merged
Merged
Conversation
Compare structural mapping keys by membership rather than insertion order and hash FrozenDict values from their logical item set. This restores CDef equality after canonical Store round trips without changing stable hashes or persistent formats. Verified with focused definition/codec tests and the good-enough representative suite.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CDefs containing mapping-valued parameters now remain equal after Store persistence canonicalizes key order.
FrozenDicthashes now honor mapping equality, so equal values remain interchangeable as set members and dictionary keys; list and tuple identity remains order-sensitive. Stable hashes and persistent formats are unchanged.Validation: 79 focused definition and codec tests passed, followed by the
good-enoughrepresentative suite with 3,641 passing tests and 30 expected skips.Fixes #51.