child_process.spawn now uses the close event #18
+6
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jscheid
added a commit
to waysact/webpack-closure-compiler
that referenced
this pull request
Nov 18, 2015
Listening to the exit event leads to occasional data loss. See nateps/connect-gzip#18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
child_process.spawnin Node.js versions prior to 0.7 use theexitevent to signal that the child process has finished; newer versions use thecloseevent. Listening to theexitevent in version >= 0.7 will result in occasional data loss if theexitevent fires beforeclose.