Skip to content

Topology ports semantics #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 28 commits into
base: feature/topology-ports
Choose a base branch
from
Open

Topology ports semantics #855

wants to merge 28 commits into from

Conversation

@Kronos3
Copy link
Collaborator

@Kronos3 Kronos3 commented Oct 22, 2025 •
edited
Loading

This PR implements topology port semantics according to the spec from #747

Interesting Changes

  • Topology uses and component instance uses were merged into a single interfaceInstanceUse
  • The component's portMap + specialPortMap were moved out into a separate PortInterface construct so that it could be reused inside topology
  • A new port instance case class was added PortInstance.Topology for wrapping ports with a new name to impement topology ports.
  • SpecLoc.Instance (was for component instance) and SpecLoc.Topology was merged into SpecLoc.Instance (interface instance). (This required a spec update).

Closes #745

@Kronos3 Kronos3 marked this pull request as ready for review October 23, 2025 04:51
@Kronos3 Kronos3 requested a review from bocchino October 30, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bocchino bocchino Awaiting requested review from bocchino

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Kronos3