Deferred from the quality-audit fix pass (#6).
Location: src/slack/formatter.ts:26
Problem: FOOTER_TEXT hardcodes the company name ("NanoCorp") inline in user-facing copy, in an otherwise tenant-agnostic, reusable formatter. Every other tenant-specific value is injected via config/ports.
Proposed fix: parameterize the org display name via config (e.g. ORG_DISPLAY_NAME, threaded to the formatter) or drop the company name from the footer so the formatter stays tenant-agnostic. The footer test only asserts on "SlackKnowledgeBot", so it won't block the change.
Why deferred: low severity; the cleanest parameterization (thread a value through vs. couple the pure formatter to config) is a small design call worth doing deliberately.
Deferred from the quality-audit fix pass (#6).
Location:
src/slack/formatter.ts:26Problem:
FOOTER_TEXThardcodes the company name ("NanoCorp") inline in user-facing copy, in an otherwise tenant-agnostic, reusable formatter. Every other tenant-specific value is injected via config/ports.Proposed fix: parameterize the org display name via config (e.g.
ORG_DISPLAY_NAME, threaded to the formatter) or drop the company name from the footer so the formatter stays tenant-agnostic. The footer test only asserts on "SlackKnowledgeBot", so it won't block the change.Why deferred: low severity; the cleanest parameterization (thread a value through vs. couple the pure formatter to config) is a small design call worth doing deliberately.