Improved client example with all request types#25
Improved client example with all request types#25DaniGuardiola wants to merge 3 commits intonameko:masterfrom DaniGuardiola:patch-1
Conversation
| for response in responses: | ||
| print(response.message) | ||
| response_messages.append(response.message) | ||
| print("responses: ", " | ".join(response_messages)) # aaaaa | bb | cccccccc |
There was a problem hiding this comment.
Thanks for expanding these.
Can you perhaps move them to the block above (the nameko service client)? Otherwise it looks like the standalone client has special abilities, whereas it's really just a different usage.
Also I wonder whether using the @rpc decorator in that example is confusing, since it's so close to @grpc. It might be better to use @http or something obviously different.
|
Examples structure now:
This way the four types of request-responses are covered, with both rpc and http method examples in the service client. I'm thinking we could even include an example of gRPC service client, to show all options (and move one of the req-res types there, given that the rpc example has two). |
|
@DaniGuardiola this is great, thanks. So per your final suggestion the example structure would be this?
I like it! |
No description provided.