Skip to content

feat: improve pr-review skill with no-ghost-review and multi-OS rules#412

Merged
jeremnaf merged 1 commit intomainfrom
feat/pr-review-skill-improvements
May 6, 2026
Merged

feat: improve pr-review skill with no-ghost-review and multi-OS rules#412
jeremnaf merged 1 commit intomainfrom
feat/pr-review-skill-improvements

Conversation

@eskenazit
Copy link
Copy Markdown
Contributor

@eskenazit eskenazit commented May 6, 2026

Related Issue

Closes #413


What does this PR do?

Improves the pr-review skill to prevent two mistakes observed in practice during the PR #395 review:

1. Ghost reviews from individual thread replies
Posting replies via pulls/comments/{id}/replies individually before the main review creates a separate ghost review object per reply on GitHub. The skill now explicitly forbids this pattern and documents how to bundle thread replies inside a single POST /reviews call using the in_reply_to field.

2. Multi-OS coverage for the in_reply_to example
Both PowerShell (Windows) and bash (Linux/macOS) variants are provided, consistent with the rest of the skill.

Version bumped: 1.1.0 -> 1.2.0.


Tests

No automated tests -- this is a documentation/skill file change. The ghost-review pattern was observed in practice during PR #395 and the fix was validated against the GitHub API.


Checklist

  • CI is green (build, tests, schema validation, security scans)
  • Rebased on latest main
  • Small and focused -- one concern per PR
  • Commit messages follow Conventional Commits

Agent Context (optional)

agent_name: GitHub Copilot
llm: Claude Sonnet 4.6
tool: VS Code Chat
confidence: high
source_event: ghost reviews observed during PR #395 review session
discovery_method: runtime_observation
review_focus: .agents/skills/pr-review/SKILL.md

@eskenazit eskenazit requested review from jeremnaf and jlouvel May 6, 2026 11:30
Copy link
Copy Markdown
Contributor

@jeremnaf jeremnaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeremnaf jeremnaf merged commit 95447ef into main May 6, 2026
2 checks passed
@jeremnaf jeremnaf deleted the feat/pr-review-skill-improvements branch May 6, 2026 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: improve pr-review skill - no-ghost-review rule and multi-OS in_reply_to example

2 participants