Skip to content

refactor!: return previous path status from Path::set_status#638

Merged
Frando merged 1 commit intomainfrom
Frando/path-status-prev
May 6, 2026
Merged

refactor!: return previous path status from Path::set_status#638
Frando merged 1 commit intomainfrom
Frando/path-status-prev

Conversation

@Frando
Copy link
Copy Markdown
Member

@Frando Frando commented May 6, 2026

Description

This makes noq::Path::set_status return the previous PathStatus, so that callers can check whether the status changed without having to call status again (which would aquire another lock needlessly).

Breaking Changes

  • changed: noq::Path::set_status now returns Result<PathStatus, SetPathStatusError>, where PathStatus is the previous path status

Change checklist

  • Self-review.
  • Documentation updates following the style guide, if relevant.
  • All breaking changes documented.

@Frando Frando requested a review from flub May 6, 2026 08:24
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/noq/pr/638/docs/noq/

Last updated: 2026-05-06T08:26:38Z

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

Performance Comparison Report

a58b89acf6c692605eaa402c9ab44241aa15f3f7 - artifacts

Raw Benchmarks (localhost)

Scenario noq upstream Delta CPU (avg/max)
large-single 5549.6 Mbps 8073.5 Mbps -31.3% 95.8% / 100.0%
medium-concurrent 5463.5 Mbps 7803.4 Mbps -30.0% 94.9% / 100.0%
medium-single 3627.9 Mbps 4749.7 Mbps -23.6% 97.3% / 150.0%
small-concurrent 3871.8 Mbps 5191.5 Mbps -25.4% 91.1% / 99.3%
small-single 3427.8 Mbps 4763.1 Mbps -28.0% 92.6% / 102.0%

Netsim Benchmarks (network simulation)

Condition noq upstream Delta
ideal N/A 4050.1 Mbps N/A
lan N/A 810.4 Mbps N/A
lossy N/A 69.8 Mbps N/A
wan N/A 83.8 Mbps N/A

Summary

noq is 28.3% slower on average

@n0bot n0bot Bot added this to iroh May 6, 2026
@github-project-automation github-project-automation Bot moved this to 🚑 Needs Triage in iroh May 6, 2026
@Frando Frando added this pull request to the merge queue May 6, 2026
Merged via the queue into main with commit 1facdd9 May 6, 2026
38 checks passed
@Frando Frando deleted the Frando/path-status-prev branch May 6, 2026 09:21
@github-project-automation github-project-automation Bot moved this from 🚑 Needs Triage to ✅ Done in iroh May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants