refactor(iroh-base)!: move tickets into their own crate #3544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Netsim report & logs for this PR have been generated and is available at: LOGS Last updated for commit: 46add96 |
rklaehn
approved these changes
Oct 15, 2025
dignifiedquire
force-pushed
the
refactor-tickets
branch
from
d7dc269 to
d4c4563
Compare
dignifiedquire
force-pushed
the
refactor-tickets
branch
from
d4c4563 to
fac5537
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These now live in https://github.com/n0-computer/iroh-tickets and will be published as
iroh-tickets.Breaking Changes
iroh-base::tickethas been removedNotes
The
0rttandtransferexamples now use justEndpointIds to connect, and not tickets anymore. Otherwise we end up in a problematic dependency tree. If necessary I can add direct addresses and relay urls to thetransferexample again