Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
I think this should be "label" to help call out that uniqueness is not enforced by the server. I've also picked an arbitrary max length & enforced it client-side, which affects the signature, because setting the label can now fail.
because auth is non-exhaustive now
running both versions at the same time is a no-go. This uses an additive approach that will work in both contexts.
Add a refresh timer to ClientActor that proactively requests a new capability token from the server before the current one expires. Refresh schedule: - >72h remaining: refresh at the halfway point of remaining lifetime - ≤72h remaining: refresh hourly - Very short-lived tokens: refresh at remaining/2 (minimum 1s) - Already expired: refresh immediately Includes a mock server test that verifies the full refresh cycle with a 4-second token.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Breaking Changes
Notes & open questions
Change checklist