Skip to content

Refactor resource management in EmailService.cs #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SebasCharria wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactor resource management in EmailService.cs #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions src/NETCore.MailKit/Core/EmailService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ private void SendEmail(string mailTo, string mailCc, string mailBcc, string subj
Check.Argument.IsNotEmpty(_to, nameof(mailTo));
Check.Argument.IsNotEmpty(message, nameof(message));

var mimeMessage = new MimeMessage();
using var mimeMessage = new MimeMessage();

//add mail from
if (!string.IsNullOrEmpty(sender?.SenderEmail) && !string.IsNullOrEmpty(sender?.SenderName))
Expand Down Expand Up @@ -285,7 +285,7 @@ private void SendEmail(string mailTo, string mailCc, string mailBcc, string subj
multipartBody.Add(new MimePart(mimeType[0], mimeType[1])
{
IsAttachment = true,
Content = new MimeContent(File.OpenRead(attach), ContentEncoding.Default),
Content = new MimeContent(File.Open(attach, FileMode.Open, FileAccess.Read, FileShare.ReadWrite | FileShare.Delete), ContentEncoding.Default),
ContentDisposition = new ContentDisposition(ContentDisposition.Attachment),
ContentTransferEncoding = ContentEncoding.Base64,
FileName = Path.GetFileName(attach),
Expand All @@ -295,10 +295,8 @@ private void SendEmail(string mailTo, string mailCc, string mailBcc, string subj
//set email body
mimeMessage.Body = multipartBody;

using (var client = _MailKitProvider.SmtpClient)
{
client.Send(mimeMessage);
}
using var client = _MailKitProvider.SmtpClient;
client.Send(mimeMessage);
}
}
}
Loading