Skip to content

Draw configurable border on the main grid#44

Open
schneider-technology wants to merge 2 commits into
museslabs:mainfrom
schneider-technology:main-grid-border
Open

Draw configurable border on the main grid#44
schneider-technology wants to merge 2 commits into
museslabs:mainfrom
schneider-technology:main-grid-border

Conversation

@schneider-technology

Copy link
Copy Markdown

The 'colors.border' setting has no effect on the main (first) grid. It only applies to the sub-grid and bisect overlays.

This draws the border on every main-grid cell for a consistent table look by reusing the existing pattern in "render_sub_grid". I hope this wasn't intentional, otherwise it would be nice to have a different option to configure the border of the "main" grid.

@schneider-technology

Copy link
Copy Markdown
Author

Hi, just wanted to know if this is working as intended? Any way to get a discussion going?

@ploMP4

ploMP4 commented Jun 28, 2026

Copy link
Copy Markdown
Member

Hi, sorry for the late reply.

This was actually intentional, but I get the need to be able to customize the internal grid border. I gave it some thought, and I am thinking of introducing something like grid_separator and grid_separator_dragging, defaulting to fully transparent to maintain the current look.

I believe this is the best direction because it also allows us to introduce things like bisect_separator in the future, since bisect mode currently suffers from the same issue.

The reason I do not want to reuse the existing border color is that I have a bright border color configured, which I like, but having it inside the grid can strain my eyes. I believe others might have the same issue.

I am happy to hear your thoughts and open to other suggestions. Otherwise, if you are okay with this direction, you can implement the changes and I will review and merge as soon as I can.

@schneider-technology

schneider-technology commented Jul 1, 2026

Copy link
Copy Markdown
Author

No worries, I was busy anyway but wanted to make sure that somebody is reading this, thanks for the reply!

Agreed on the split - 'separator' for the inner lines, 'border' for the outer outline. On naming I'd lean 'separator' / 'separator_subgrid' / 'separator_dragging' / 'separator_bisect' (type first, mirroring 'border' / 'border_dragging'), defaulting to fully transparent, so the current look is unchanged. I feel like leaving out "grid" is fine, since it is implied with the separator already. For this PR however I won't tackle dragging.

Separately - and I think this is actually a distinct feature (so a fresh PR) - while dragging it might help to also draw the outer border on the main grid (and bisect), the way the sub-grid already does, so it's more obvious you're in drag mode. Ideally with a way to disable it or set its color separately. One can then decide if they prefer the border or the separator (or even both). The only conflict would be, that bisecting also sets a border, which in my opinion however shouldn't be necessary?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants