Simplify DeclareModuleSetup and migrate muse_learn #31098
+423
−416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbjeukendrup
force-pushed
the
declaremodulesetup
branch
4 times, most recently
from
a049839 to
80cb300
Compare
Instead of having a two-step process with an ever growing list of variables, where it isn’t clear which includes/defines are private and which are public, let’s have a simple function that sets up a target in the correct way, and then use standard CMake APIs to set sources, includes and defines in a transparent way.
cbjeukendrup
force-pushed
the
declaremodulesetup
branch
from
80cb300 to
03a48a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.